Conversation
3v1n0
left a comment
3v1n0
left a comment
There was a problem hiding this comment.
Yeah, better to release early these fixes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
==========================================
- Coverage 85.71% 85.64% -0.08%
==========================================
Files 82 82
Lines 5768 5794 +26
Branches 109 111 +2
==========================================
+ Hits 4944 4962 +18
- Misses 769 776 +7
- Partials 55 56 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We want wait #987 here? |
|
I found out that the workflow started for pushing the tag does not merge main, so I'm using the artifacts built from that |
|
Even better! |
| authd (0.5.6) UNRELEASED; urgency=medium | ||
| authd (0.5.6) questing; urgency=medium | ||
|
|
||
| * New launchpad upload |
There was a problem hiding this comment.
Mh, this was needed for?
I would like that we get a way to avoid to do uploads of invalid tags or ubuntu uploads though, maybe using your local fork and more ~pre uploads?
Maybe specify it better in changelog.
However... Please also use -v0.5.4 when generating the *.changes file to upload to the stable PPA :)
There was a problem hiding this comment.
I did v0.5.5~pre1 for the testing. when I finalized the release, I removed that suffix and uploaded to launchpad to build the 0.5.5 release, and only when that was uploaded to the edge PPA I noticed in the diff that it contains unexpected changes from main
There was a problem hiding this comment.
However... Please also use -v0.5.4 when generating the *.changes file to upload to the stable PPA :)
ah, too late, 0.5.6 is already building on launchpad with -v0.5.5 :/
There was a problem hiding this comment.
So we have two options, add another 0.5.7 entry or release with the .changes files with the diff between 0.5.6 and 0.5.5 (where the latter contains the changes from main)
There was a problem hiding this comment.
Not a big deal. But next time remember in order to ensure that the changes we generate is meaningful, so ignoring the minor updates
There was a problem hiding this comment.
Yeah sure, makes sense, I just didn't think about it
There was a problem hiding this comment.
Oh, I actually see that's still in edge only, no?
So if that is the case, you can just regenerate the changes file from that same source when uploading to stable no?
There's no need to do it through the lp UI (and sources are still the same, so no risk)
There was a problem hiding this comment.
Ok, will do that now
3 participants
Uh oh!
There was an error while loading. Please reload this page.